Skip to content

fix(AIP-165): explicitly allow filter wildcard#1539

Merged
quirogas merged 1 commit intoaip-dev:masterfrom
noahdietz:aip-165-wildcard
Jul 23, 2025
Merged

fix(AIP-165): explicitly allow filter wildcard#1539
quirogas merged 1 commit intoaip-dev:masterfrom
noahdietz:aip-165-wildcard

Conversation

@noahdietz
Copy link
Copy Markdown
Collaborator

Since the filter field for Purge requests are REQUIRED, an empty string is not allowed, which means a specific value for indicating "delete everything" is necessary. We already have this pattern in parts of AIP-160 where support for "*" as a wildcard is allowed. Make that explicit here.

Internal bug http://b/431251818

@noahdietz noahdietz requested a review from a team as a code owner July 23, 2025 16:45
@noahdietz noahdietz requested review from neomagus00 and quirogas and removed request for neomagus00 July 23, 2025 16:45
Copy link
Copy Markdown
Contributor

@quirogas quirogas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@quirogas quirogas merged commit 8fd98c4 into aip-dev:master Jul 23, 2025
2 checks passed
@noahdietz noahdietz deleted the aip-165-wildcard branch July 23, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants