fix: Name of special header for AWS credential#946
fix: Name of special header for AWS credential#946amanda-tarafa merged 4 commits intoaip-dev:masterfrom
Conversation
|
FYI: @jskeet |
| `us-east-1d`. The region should be determined by stripping the last | ||
| character, e.g. `us-east-1`. | ||
| - Check the environment variables `ACCESS_ACCESS_KEY_ID`, | ||
| - Check the environment variables `AWS_ACCESS_ACCESS_KEY_ID`, |
There was a problem hiding this comment.
Two ACCESS? The documentation for the CI says AWS_ACCESS_KEY_ID:
https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html
There was a problem hiding this comment.
Oh, thanks for catching this! I'll push a fix shortly.
amanda-tarafa
force-pushed
the
patch-1
branch
from
de65f87 to
35b03cf
Compare
|
Ping. |
The JSON example is correct. See b/151677419 for more context.
All the headers in the example, except for Authorization itself should be included on the signed header list.
No need to fetch the token if environment variables for both the region and the security credentials have been provided.
amanda-tarafa
force-pushed
the
patch-1
branch
from
35b03cf to
f4b6511
Compare
|
I've rebased and resolve conflicts. This was never merged because it never got the required reviews. Can someone from @aip-dev/auth and @aip-dev/google review this, @lsirac already approved. Thanks. |
|
(I've set it to auto merge, as soon as it is approved, it will be merged) |
|
I can approve for @aip-dev/google but that is more top-level OWNERS here. Do you think someone from @aip-dev/auth should Approve? |
noahdietz
left a comment
noahdietz
left a comment
There was a problem hiding this comment.
Please update the Changelog as well
Done! |
4 participants
The JSON example is correct.
See b/151677419 for more context.