Skip to content

ADSP-SC598 upstream driver changes v2#2908

Merged
pamolloy merged 18 commits intoadsp-6.12.38-yfrom
adsp-6.12.38-y-patchset
Nov 4, 2025
Merged

ADSP-SC598 upstream driver changes v2#2908
pamolloy merged 18 commits intoadsp-6.12.38-yfrom
adsp-6.12.38-y-patchset

Conversation

@artursartamonovsadi
Copy link
Copy Markdown

@artursartamonovsadi artursartamonovsadi commented Aug 25, 2025

Minimal patch set to boot into ADSP-SC598-SOM with initramfs to UART Linux shell.
Based on v1 sent to kernel mailinglist. Tested with ADSP-SC598-SOM RevC

PR Type

  • Bug fix (a change that fixes an issue)
  • [x ] New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • [x ] I have conducted a self-review of my own code changes
  • [x ] I have tested the changes on the relevant hardware
  • [x ] I have updated the documentation outside this repo accordingly (if there is the case)

@pamolloy pamolloy requested a review from gastmaier August 26, 2025 05:59
@pamolloy
Copy link
Copy Markdown
Collaborator

pamolloy commented Aug 26, 2025

Thanks so much for posting this! @UtsavAgarwalADI and I were chatting about the sign off section for an earlier set of patches. It is probably easier to just discuss it in person, but also take a look at https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by. The two examples at the end of the section are especially helpful.

@pamolloy pamolloy added this to ADSP Aug 26, 2025
@pamolloy pamolloy moved this to In Development in ADSP Aug 26, 2025
@pamolloy
Copy link
Copy Markdown
Collaborator

pamolloy commented Aug 26, 2025

It would be good to link to the original mailing list review in the description:

https://lore.kernel.org/lkml/20240912-test-v1-0-458fa57c8ccf@analog.com/

pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
Comment thread arch/arm64/Kconfig.platforms
pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
Comment thread arch/arm64/Kconfig.platforms Outdated
pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
Comment thread drivers/clk/adi/clk-adi-pll.c Outdated
pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
Comment thread drivers/clk/adi/clk.h Outdated
pamolloy
pamolloy reviewed Aug 26, 2025
View reviewed changes
Comment thread drivers/clk/adi/clk.h Outdated
@pamolloy
Copy link
Copy Markdown
Collaborator

pamolloy commented Sep 25, 2025

@artursartamonovsadi tested it and it was able to boot. We may need to revert the I2C driver, but I'll figure that out as I rebase adsp-main-6.12 onto these patches. This is just the first round of clean-up so it doesn't need to be perfect.

artursartamonovsadi
artursartamonovsadi commented Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went trough mailinglist comments and added if those wheren't addressed, so possible to track those here.

Comment thread drivers/i2c/busses/i2c-adi-sc5xx.c
struct clk *sclk;
};

static void adi_twi_handle_interrupt(struct adi_twi_iface *i2c,
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change name from adi_twi to match driver to adi_i2c

Comment thread arch/arm64/boot/dts/adi/sc598-som.dtsi Outdated
/ {
chosen {
stdout-path = &uart1;
bootargs = "earlycon=adi_uart,0x31003000 console=ttySC0,115200 mem=224M";
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from the mailinglist:

You should not need the mem= and earlycon= arguments, as that data
is already part of the stdout-path property and the memory node.

Second comment:
Drop entire bootargs. Look how other SoCs do it, if you need port speed.

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi Outdated
serial0 = &uart0;
serial2 = &uart2;
serial3 = &uart3;
};
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from mailinglist:

The aliases are board specific, please only list the ones
that are actually enabled and wired on on a particular
board, and make the aliases match the labels on the board
rather than the internal components of hte chip.

Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to board DTS

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi
reg = <0x0 0x0>;
enable-method = "spin-table";
cpu-release-addr = <0x0 0xdeadbeef>;
clocks = <&clk_cgu0 ADSP_CLK_ARM>, <&clk_cgu0 ADSP_CLK_DDR>;
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments from mailinglist:

Is that the actual address? It looks like some placeholder
that should not have been here.

Comment thread Documentation/devicetree/bindings/clock/adi,sc5xx-clocks.yaml Outdated
#clock-cells = <1>;
clocks = <&sys_clkin0>, <&sys_clkin1>;
clock-names = "sys_clkin0", "sys_clkin1";
status = "okay";
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove status

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi Outdated
clock-output-names = "sys_clkin0";
};

sys_clkin1: oscillator@2 {
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from mailinglist:

How are these properties of the SoC? Where are they located physically?
See DTS coding style.

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi Outdated
status = "okay";
};

scb: scb-bus {
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from mailinglist:

What is scb-bus?

See DTS coding style or any other SoC. This is supposed to be just sco@
with proper unit address.

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi Outdated
status = "disabled";
};

i2c0: twi@31001400 {
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment from mailinglist:

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation


Completely wrong order of properties. Please follow DTS coding style.

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi Outdated
#address-cells = <1>;
#size-cells = <0>;
compatible = "adi,sc5xx-i2c";
reg = <0x31001400 0xFF>;
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowe case hex?

Comment thread arch/arm64/boot/dts/adi/sc59x-64.dtsi Outdated
gpio-ranges = <&pinctrl0 0 96 16>;
};

gph: gport@31004380 {
Copy link
Copy Markdown
Author

@artursartamonovsadi artursartamonovsadi Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment:
Node names should be generic

@pamolloy pamolloy closed this Oct 30, 2025
@github-project-automation github-project-automation Bot moved this from In Development to Done in ADSP Oct 30, 2025
@pamolloy pamolloy reopened this Oct 30, 2025
@gastmaier gastmaier closed this Nov 3, 2025
@gastmaier gastmaier reopened this Nov 3, 2025
artursartamonovsadi and others added 18 commits November 3, 2025 15:43
@artursartamonovsadi @pamolloy
arm64: Add initial support for ADSP-SC59x SoCs
592ee61 
Add headers for GPIO port management, RCU and general system
configuration

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Co-developed-by: Arturs Artamonovs <arturs.artamonovs@analog.com>
Signed-off-by: Arturs Artamonovs <arturs.artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
reset: Add driver for ADI ADSP-SC59x reset controller
8f88f88 
Support triggering a software reset

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
dt-bindings: arm64: Add bindings for ADSP-SC5xx reset driver
6fc62b6 
Add bindings for the reset controller in ADI ADSP-SC5xx SoCs

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
dt-bindings: arm64: adi: Add bindings for ADSP-SC5xx based boards
521d83c 
Add bindings for ADI evaluation boards using ADSP-SC59x SoCs

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
clock: Add PLL driver for ADSP-SC5xx SoCs
2b8338a 
Implement the clock tree without dynamic PLL rate change

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
dt-bindings: clock: adi: Add bindings for ADSP-SC5xx clock tree
64f0e3b 
Add device tree bindings for the ADSP-SC5xx clock distribution unit
(CDU) and clock generation unit (CGU)

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@pamolloy
clock: Add clock driver for ADSP-SC5xx SoCs
ba16938 
Add ADSP-SC5xx clock driver

Co-developed-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Co-developed-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Utsav Agarwal <Utsav.Agarwal@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
gpio: Add gpio driver for ADSP-SC5xx SoCs
53ce6df 
- Support all GPIO ports
- Each gpio support seperate PINT interrupt controller

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
dt-bindings: gpio: adi: Add bindings for ADSP-SC5xx GPIO PORT driver
78e0c74 
Add bindings for ADSP-SC5xx general-purpose ports, pin multiplexing,
general-purpose input/output (GPIO) functionality, and pin interrupts.

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
dt-bindings: pinctrl: adi: Add bindings for the ADSP-SC5xx pinctrl
b502a8e 
Add bindings for the ADSP-SC5xx pinmux control

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@pamolloy
pinctrl: Add pinctrl driver for ADSP-SC5xx SoCs
a75ddcb 
Support switching GPIO pin functions

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
i2c: Add driver for ADSP-SC5xx SoCs
66d6a68 
Add I2C support on ADSP-SC5xx SoCs

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
dt-bindings: i2c: Add bindings for ADSP-SC5xx I2C/TWI
1bc8b2e 
Add bindings for ADSP-SC5xx I2C/TWI

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
serial: Add UART driver for ADSP-SC5xx SoCs
5f6e8cd 
- Support FIFO mode
- Support earlyprintk
- Support Enable Divide By One support, for higher clock resolutions.

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@pamolloy
dt-bindings: serial: adi: Add bindings for the ADSP-SC5xx UART
3bdd549 
Add bindings for the ADSP-SC5xx UART

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
arm64: dts: adi: Add support for ADSP-SC598 eval boards
242ae8a 
Add support for the ADSP-SC59x SoC, EV-SC598-SOM and EV-SOMCRR-EZKIT

Co-developed-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Signed-off-by: Nathan Barrett-Morrison <nathan.morrison@timesys.com>
Co-developed-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Greg Malysa <malysagreg@gmail.com>
Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@artursartamonovsadi @pamolloy
MAINTAINERS: Add maintainer for ADSP-SC5xx SoCs
9cc0b9e 
Add Arturs Artamonov as the maintainer of ADSP-SC5xx SoCs

Signed-off-by: Arturs Artamonovs <Arturs.Artamonovs@analog.com>
Signed-off-by: Philip Molloy <philip.molloy@analog.com>
@pamolloy
arm64: defconfig: Add initial support for the ADSP-SC598
6ebb1f7 
Add initial support for the ADSP-SC598

Signed-off-by: Philip Molloy <philip@philipmolloy.com>
@pamolloy pamolloy force-pushed the adsp-6.12.38-y-patchset branch from da5301b to 6ebb1f7 Compare November 3, 2025 14:43
@pamolloy
Copy link
Copy Markdown
Collaborator

pamolloy commented Nov 3, 2025

Assuming this builds 🤞, I'm going to merge it.

@artursartamonovsadi I made some small changes to the dt-bindings and moved two include/dt-bindings/*/*.h into commits with the YAML.

@pamolloy pamolloy merged commit 30a2b5f into adsp-6.12.38-y Nov 4, 2025
14 checks passed
@pamolloy pamolloy deleted the adsp-6.12.38-y-patchset branch November 4, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pamolloy pamolloy pamolloy left review comments

@vasbimpikasadi vasbimpikasadi Awaiting requested review from vasbimpikasadi

@CalebEthridgeADI CalebEthridgeADI Awaiting requested review from CalebEthridgeADI

@nunojsa nunojsa Awaiting requested review from nunojsa nunojsa is a code owner

@mhennerich mhennerich Awaiting requested review from mhennerich mhennerich is a code owner

@dbogdan dbogdan Awaiting requested review from dbogdan dbogdan is a code owner

@gastmaier gastmaier Awaiting requested review from gastmaier

Assignees

@artursartamonovsadi artursartamonovsadi

Labels

None yet

Projects

ADSP
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@artursartamonovsadi @pamolloy @gastmaier @nunojsa