iio: trx-rf: ad9088: Fix uninitialized dev_clk local variable in probe#3305
Merged
nunojsa merged 1 commit intoxlnx/release/v6.12.y-2026r1from May 5, 2026
Merged
Conversation
nunojsa
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
rbolboac and
stefpopa
as code owners
Commit 92e2dca ("iio: trx-rf: ad9088: Update API v2.0.10, FW v2.0.6, device-profile v10.1.3") stored the dev_clk pointer in struct ad9088_phy and used phy->dev_clk for get/configure/enable, but probe() already had a local `dev_clk` variable that is passed to __clk_get_name() later. This left the local variable uninitialized, triggering a -Wuninitialized warning and potential undefined behavior. Fix this by using the local variable consistently and dropping the now-unused struct member. Fixes: 92e2dca ("iio: trx-rf: ad9088: Update API v2.0.10, FW v2.0.6, device-profile v10.1.3") Signed-off-by: Nuno Sá <nuno.sa@analog.com> (cherry picked from commit 6422dfe)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 92e2dca ("iio: trx-rf: ad9088: Update API v2.0.10, FW v2.0.6, device-profile v10.1.3") stored the dev_clk pointer in struct ad9088_phy and used phy->dev_clk for get/configure/enable, but probe() already had a local
dev_clkvariable that is passed to __clk_get_name() later. This left the local variable uninitialized, triggering a -Wuninitialized warning and potential undefined behavior.Fix this by using the local variable consistently and dropping the now-unused struct member.
Fixes: 92e2dca ("iio: trx-rf: ad9088: Update API v2.0.10, FW v2.0.6, device-profile v10.1.3")
(cherry picked from commit 6422dfe)
PR Type
PR Checklist