docs(docker): Describe current state of docker image security plus minor fixes#836
Conversation
…s dir (and sort list)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request updates a CI workflow file by modifying the criteria for file monitoring in the "Get changed Docker related files" step. The workflow now explicitly includes the Dockerfile, Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant CI as CI Workflow
participant Detector as File Detector
participant Next as Subsequent Steps
Dev->>CI: Push commit with changes
CI->>Detector: Execute "Get changed Docker related files" step
Detector-->>CI: Return list of explicitly included files
CI->>Next: Trigger subsequent steps if matching files detected
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Docker image build process by updating the file paths used by the "changed-files" step and reordering the list of watched files.
- Replace "tools/.sh" with "tools/install/.sh" to target the correct scripts directory.
- Adjust the file list order for consistency.
Comments suppressed due to low confidence (1)
.github/workflows/build-image-test.yaml:46
- The updated files list does not appear to be sorted alphabetically as indicated by the commit message. Please reorder the file list to ensure consistent sorting.
Dockerfile
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build-image-test.yaml (1)
1-127: Consider Scheduled Docker Image Rebuilds
The PR objectives mention scheduling a Docker image rebuild on a biweekly basis to ensure the image remains up-to-date. Although this change focuses on the “changed-files” step, it might be beneficial to add a scheduled trigger to this workflow. For example, adding aschedulekey with an appropriate cron expression could automate periodic rebuilds.Would you like assistance in drafting the necessary modifications?
🧰 Tools
🪛 actionlint (1.7.4)
29-29: label "ubuntu-24.04-arm" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build-image-test.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: 🧪 Tests / pytest@🐍3.9@macos-14
- GitHub Check: Ubuntu ARM
- GitHub Check: pre-commit
- GitHub Check: Ubuntu x64
🔇 Additional comments (1)
.github/workflows/build-image-test.yaml (1)
44-48: Clarify and Confirm the File Inclusion and Sorting Logic
The updated list now explicitly includes the Docker-related files (“Dockerfile”, “tools/entrypoint.sh”, and “tools/install/*.sh”) instead of using more generic patterns. This improves clarity about which files trigger a rebuild and appears to be sorted in a logical order. Please confirm that this change correctly reflects the intended monitored files and that no critical file is being accidentally omitted.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docker image build process by correcting the scripts directory used in the changed-files step and reordering the list of files.
- Corrects the scripts path from tools/.sh to tools/install/.sh
- Updates the file list ordering in the GitHub Actions workflow
Comments suppressed due to low confidence (2)
.github/workflows/build-image-test.yaml:48
- Verify that the updated path 'tools/install/.sh' correctly reflects the intended directory structure for the Docker image build process compared to the previous 'tools/.sh'.
tools/install/*.sh
.github/workflows/build-image-test.yaml:46
- [nitpick] The file list appears intended to be sorted but is not in strict alphabetical order. Consider sorting all file paths alphabetically for consistency and clarity.
Dockerfile
We already have it in |
Ah, thanks. Apologies I didn't double check it thoroughly enough 🤦🏻 |
MaxymVlasov
changed the title
changed-files step to correct scripts dir (and sort list)
MaxymVlasov
deleted the
fix/Point_Docker_build_workflow_to_correct_scripts_dir
branch
|
This PR is included in version 1.98.0 🎉 |
changed-filesstep to correct scripts dirRelates to #835 (this PR should trigger a one-off Docker image rebuild to bring it up-to-date as requested in linked issue)
@MaxymVlasov Maybe it might make sense to schedule Docker image rebuild every other week, biweekly, or so?