chore(docker debug): Display opentofu & terraform versions#839
chore(docker debug): Display opentofu & terraform versions#839MaxymVlasov merged 4 commits intoantonbabenko:masterfrom
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe Dockerfile was updated to modify the commands that log the versions of the Changes
Sequence Diagram(s)(No sequence diagrams provided as changes do not alter control flow.) 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Note 🎁 Summarized by CodeRabbit FreeYour organization has reached its limit of developer seats under the Pro Plan. For new users, CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please add seats to your subscription by visiting https://app.coderabbit.ai/login.If you believe this is a mistake and have available seats, please assign one to the pull request author through the subscription management page using the link above. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Dockerfile (1)
87-87: Improve tofu version logging consistency.
The updated command now correctly executes the tofu version retrieval (i.e../tofu --version | head -n 1) and prefixes it with "tofu". However, in theelseclause the output is"opentofu SKIPPED", which is inconsistent with the positive branch and with the expected output. To enhance clarity and consistency, consider updating theelseoutput to"tofu SKIPPED".- (if [ "$OPENTOFU_VERSION" != "false" ]; then echo "tofu $(./tofu --version | head -n 1)" >> $F; else echo "opentofu SKIPPED" >> $F ; fi) && \ + (if [ "$OPENTOFU_VERSION" != "false" ]; then echo "tofu $(./tofu --version | head -n 1)" >> $F; else echo "tofu SKIPPED" >> $F ; fi) && \
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🔇 Additional comments (1)
Dockerfile (1)
88-88: Terraform version logging meets the requirements.
The command now executes the terraform version retrieval (i.e../terraform --version | head -n 1) and correctly prefixes the output with "terraform". This provides a clearer display of the version information as intended by the PR.
Co-authored-by: George L. Yermulnik <yz@yz.kiev.ua>
MaxymVlasov
left a comment
There was a problem hiding this comment.
Nice catch!
Your changes are ready to go, but we are currently blocked by codecov/codecov-action#1794 as it breaks our required CI checks. If it will not be fixed soon, I'll disable these checks and will merge your PR right after
|
This PR is included in version 1.98.0 🎉 |
Put an
xinto the box if that apply:Description of your changes
Before
After
How can we test changes