chore(codecov): Ignore errors during codecov upload#846
Merged
MaxymVlasov merged 3 commits intomasterfrom Mar 21, 2025
Merged
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe pull request modifies the GitHub Actions workflow by updating the "Upload test results to Codecov" step. A new line, Changes
Sequence Diagram(s)sequenceDiagram
participant Runner as Workflow Runner
participant Codecov as Codecov Upload Step
participant Next as Subsequent Steps
Runner->>Codecov: Execute Codecov upload step
Note right of Codecov: Known bug may cause failure
Codecov-->>Runner: Return error (ignored due to continue-on-error)
Runner->>Next: Proceed with subsequent steps
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
antonbabenko
previously approved these changes
Mar 21, 2025
yermulnik
reviewed
Mar 21, 2025
Comment on lines
+403
to
+405
| # There is a bug in action which provokes it to fail during upload | ||
| # Related issue: https://github.com/codecov/codecov-action/issues/1794 | ||
| continue-on-error: true |
Collaborator
There was a problem hiding this comment.
IMHO it may make sense to add FIXME remark and current date to the comment to keep track of this quirk which we probably want to revert later 🤔
Suggested change
| # There is a bug in action which provokes it to fail during upload | |
| # Related issue: https://github.com/codecov/codecov-action/issues/1794 | |
| continue-on-error: true | |
| # There is a bug in action which provokes it to fail during upload | |
| # Related issue: https://github.com/codecov/codecov-action/issues/1794 | |
| # FIXME: set to `false' once linked issue is resolved (20250321) | |
| continue-on-error: true |
Collaborator
Author
There was a problem hiding this comment.
You can get date from git metadata
Collaborator
There was a problem hiding this comment.
And browse git log to get when the comment first appeared if it's updated multiple times... I prefer a more human-friendly inline comment.
Up to you though.
yermulnik
approved these changes
Mar 21, 2025
Owner
|
This PR is included in version 1.98.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for codecov/codecov-action#1794
Close #843