Skip to content

fix(WSL): Fix parallelism support for WSL systems with enabled systemd #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yermulnik merged 6 commits into from
Apr 6, 2025
Merged

fix(WSL): Fix parallelism support for WSL systems with enabled systemd #872

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eaf75a3
chore(_common.sh): Add `WSLInterop-late` file check in `get_cpu_num`
yermulnik Apr 6, 2025
384091b
Fix typo
yermulnik Apr 6, 2025
be1051f
pre-commit fixes
Apr 6, 2025
62953da
Streamline condition wrapping
yermulnik Apr 6, 2025
d3066b2
make WSLInterop local var readonly
yermulnik Apr 6, 2025
759fcb7
Also check `/run/WSL` file does not exist
yermulnik Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion hooks/_common.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,10 @@ function common::get_cpu_num {

local cpu_quota cpu_period cpu_num

local wslinterop_path="/proc/sys/fs/binfmt_misc/WSLInterop"
Comment thread
yermulnik marked this conversation as resolved.
Outdated

if [[ -f /sys/fs/cgroup/cpu/cpu.cfs_quota_us &&
! -f /proc/sys/fs/binfmt_misc/WSLInterop ]]; then # WSL have cfs_quota_us, but WSL should be checked as usual Linux host
(! -f "${wslinterop_path}" && ! -f "${wslinterop_path}-late") ]]; then # WSL has cfs_quota_us, but WSL should be checked as usual Linux host
# Inside K8s pod or DinD in K8s
cpu_quota=$(< /sys/fs/cgroup/cpu/cpu.cfs_quota_us)
cpu_period=$(cat /sys/fs/cgroup/cpu/cpu.cfs_period_us 2> /dev/null || echo "$cpu_quota")
Expand Down
Loading