chore(ci): Prepare to switch to Merge Queue for PR merging#893
chore(ci): Prepare to switch to Merge Queue for PR merging#893MaxymVlasov merged 1 commit intomasterfrom
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe GitHub Actions workflow trigger configurations were updated across several workflow files to include the Changes
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (4)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Pull Request Overview
Adds the merge_group trigger to existing GitHub workflows so they run when using the Merge Queue feature.
- Introduce
merge_groupevent alongsidepull_requestfor CI jobs - Ensure pre-commit checks, dependency review, CodeQL, and Docker smoke tests cover Merge Queue merges
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/pre-commit.yaml | Add merge_group trigger to pre-commit checks |
| .github/workflows/dependency-review.yml | Add merge_group trigger to dependency review |
| .github/workflows/codeql.yml | Add merge_group trigger to CodeQL workflow |
| .github/workflows/build-image-test.yaml | Add merge_group trigger to Docker build tests |
yermulnik
left a comment
There was a problem hiding this comment.
Copilot highlighted an interesting point: GHA docs say «specifying the activity type will keep your workflow specific if more activity types are added in the future» — why would you want to rely upon the assumption that activity types, added in future, will match the purpose of what you're implementing tin this PR? 🤔
ps: when you resolve PR review comments w/o any type of feedback (comment or commit), it produces more questions than answers =)
|
This PR is included in version 1.99.1 🎉 |
Description of your changes
I previously tried to automate Renovate PR merges, but it works poorly, plus it's time to time violate review process.
So, to address known issues with time-consuming merge of many Renovate PRs at once, make OpenSSF scorecard happier in terms of branch protection rules (#712) and make finally get ability to merge many Renovate PRs at once - let's enable Merge queue for PRs.
For this, required:
UPD. Merge Queue is accessible only for organizations... So we're can't use it right now, but I'll merge it anyway in case if we will migrate to organization one day