Skip to content

ci(action-semantic-pull-request): Fix for PRs from forks#941

Merged
MaxymVlasov merged 4 commits intomasterfrom
test/action-semantic-pull-request
Oct 9, 2025
Merged

ci(action-semantic-pull-request): Fix for PRs from forks#941
MaxymVlasov merged 4 commits intomasterfrom
test/action-semantic-pull-request

Conversation

@yermulnik
Copy link
Copy Markdown
Collaborator

@yermulnik yermulnik commented Oct 9, 2025

Suppress zizmor's error: we do want pull_request_target - https://github.com/amannn/action-semantic-pull-request#event-triggers

@yermulnik yermulnik changed the title test: action-semantic-pull-request ci(action-semantic-pull-request): test Oct 9, 2025
@yermulnik yermulnik changed the title ci(action-semantic-pull-request): test ci(action-semantic-pull-request): Test Oct 9, 2025
@yermulnik yermulnik changed the title ci(action-semantic-pull-request): Test ci(action-semantic-pull-request): Fix for PRs from forks Oct 9, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 9, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Improved pull request title validation in our CI workflow to increase reliability and coverage.
    • Validation now runs consistently on reopened PRs in addition to opened, edited, and synchronized updates.
    • Existing behavior and annotations for previously supported PR events remain unchanged.
    • This streamlines contributor experience and helps maintain consistent PR titles without affecting application features or user-facing functionality.

Walkthrough

Switched GitHub Actions workflow trigger from pull_request to pull_request_target and added the reopened pull request event type in .github/workflows/pr-title.yml.

Changes

Cohort / File(s) Summary of changes
CI workflow trigger update
.github/workflows/pr-title.yml
Changed workflow trigger from pull_request to pull_request_target; added reopened to the list of PR event types (retained opened, edited, synchronize).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Dev as Developer
  participant GH as GitHub
  participant WF as pr-title Workflow

  Dev->>GH: Open / Edit / Synchronize / Reopen PR
  Note right of GH #DDDDFF: Events: opened, edited, synchronize, reopened
  GH-->>WF: emit pull_request_target
  activate WF
  WF->>WF: run title validation jobs/steps
  WF-->>GH: post status / checks
  deactivate WF
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request description is missing entirely and does not provide any context or details about the changes made, leaving reviewers without a summary of the updates to the CI workflow. Please add a descriptive summary of the changes made to the GitHub Actions workflow, including the switch to pull_request_target and the addition of the reopened event, to help reviewers understand the intent of this fix.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title “ci(action-semantic-pull-request): Fix for PRs from forks” clearly identifies the component and the primary change by summarizing the fix to enable the semantic pull request action to work with forked pull requests in a concise, readable manner.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch test/action-semantic-pull-request

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 611dc08 and 23d0683.

📒 Files selected for processing (1)
  • .github/workflows/pr-title.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/pr-title.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@macos-13
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@macos-14
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@macos-14
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@macos-13
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@macos-14
  • GitHub Check: 🧹 Linters / pre-commit@🐍3.13@ubuntu-latest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@yermulnik yermulnik force-pushed the test/action-semantic-pull-request branch from 30aaa0d to 611dc08 Compare October 9, 2025 11:26
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6e63792 and 611dc08.

📒 Files selected for processing (1)
  • .github/workflows/pr-title.yml (1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Common issues check
.github/workflows/pr-title.yml

[error] 3-9: Zizmor audit failure: dangerous workflow trigger detected (pull_request_target is insecure). Use of pull_request_target is almost always insecure; review workflow triggers.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: 🧹 Linters / metadata-validation@🐍3.13@ubuntu-latest
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@ubuntu-24.04
  • GitHub Check: 🧹 Linters / pre-commit@🐍3.13@ubuntu-latest
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.11@ubuntu-24.04
  • GitHub Check: 🧪 Tests / pytest@🐍3.12@ubuntu-24.04
  • GitHub Check: 🧪 Tests / pytest@🐍3.13@ubuntu-24.04
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.9@ubuntu-24.04
  • GitHub Check: 🧪 Tests / pytest@🐍3.10@windows-2025
  • GitHub Check: 🧪 Tests / pytest@🐍3.13@windows-2025
  • GitHub Check: Lint GitHub Actions / 🔐 Analyze repo with zizmor 🌈

Comment thread .github/workflows/pr-title.yml
@yermulnik yermulnik marked this pull request as ready for review October 9, 2025 11:43
Copilot AI review requested due to automatic review settings October 9, 2025 11:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow for PR title validation to work with pull requests from forks by switching from pull_request to pull_request_target trigger and adding security configuration.

  • Changed trigger from pull_request to pull_request_target to enable fork compatibility
  • Added zizmor security linting ignore comment for the dangerous trigger
  • Added reopened event type to the workflow triggers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/pr-title.yml
@MaxymVlasov MaxymVlasov merged commit 5b4638b into master Oct 9, 2025
48 checks passed
@MaxymVlasov MaxymVlasov deleted the test/action-semantic-pull-request branch October 9, 2025 11:49
@antonbabenko
Copy link
Copy Markdown
Owner

This PR is included in version 1.102.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants