Skip to content

Commit ac047b6

Browse files
fix flaky AMQ6133PersistJMSRedeliveryTest using Wait.waitFor (#1872)
1 parent e612481 commit ac047b6

1 file changed

Lines changed: 15 additions & 2 deletions

File tree

activemq-unit-tests/src/test/java/org/apache/activemq/bugs/AMQ6133PersistJMSRedeliveryTest.java

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@
4545
import org.apache.activemq.broker.region.policy.PolicyMap;
4646
import org.apache.activemq.store.kahadb.KahaDBPersistenceAdapter;
4747
import org.apache.activemq.store.kahadb.MessageDatabase;
48+
import org.apache.activemq.util.Wait;
4849
import org.apache.commons.io.FileUtils;
4950
import org.apache.commons.io.filefilter.TrueFileFilter;
5051
import org.apache.commons.io.filefilter.WildcardFileFilter;
@@ -89,11 +90,23 @@ public void testPersistJMSRedeliveredMessageLossOnIndexRebuild() throws Exceptio
8990

9091
restart();
9192

92-
assertEquals(msgCount, getProxyToQueue(QUEUE_NAME).getQueueSize());
93+
assertTrue("Queue size should match expected count: " + msgCount, Wait.waitFor(() -> {
94+
try {
95+
return getProxyToQueue(QUEUE_NAME).getQueueSize() == msgCount;
96+
} catch (Exception e) {
97+
return false;
98+
}
99+
}));
93100

94101
restartWithRecovery(getPersistentDir());
95102

96-
assertEquals(msgCount, getProxyToQueue(QUEUE_NAME).getQueueSize());
103+
assertTrue("Queue size should match expected count: " + msgCount, Wait.waitFor(() -> {
104+
try {
105+
return getProxyToQueue(QUEUE_NAME).getQueueSize() == msgCount;
106+
} catch (Exception e) {
107+
return false;
108+
}
109+
}));
97110
}
98111

99112
@Before

0 commit comments

Comments
 (0)