AVRO-4249: [java] provide a cache of schema to avoid building#3746
Open
mkeskells wants to merge 3 commits intoapache:mainfrom
Open
AVRO-4249: [java] provide a cache of schema to avoid building#3746mkeskells wants to merge 3 commits intoapache:mainfrom
mkeskells wants to merge 3 commits intoapache:mainfrom
Conversation
mkeskells
force-pushed
the
AVRO-4249-schema-cache
branch
from
65f4513 to
34e6910
Compare
add tests and a benchmark
Contributor
Author
|
Benchmark results for PR change. Nothing unexpected Significant recuction in allocation and CPU time with this change |
Contributor
Author
|
Could a maintainer please add the performance label to this PR? |
Contributor
Author
|
I have fixed the licence issues reported in the build (missing licence header). |
Contributor
Author
|
I finally got o the bottom of the memmory leak I was chasing when I observed the problem that this fixes- its https://issues.apache.org/jira/browse/AVRO-4253, a memory leak, which in my environment was holding only 200Gb of Schemas due to the leak. Mostly fixed by this PR |
Contributor
|
Hey, pardon me! I appreciate the work, and I'll take a closer look soon -- we're going to do a 1.13.0 release just after the next one 1.12.2, and this should be in it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
To improve the performance of parsing files.
In an environment where we parse 10k to 100K (generally very small) files that are small, and use the same schema, or a handful of schemas we see many Tb of garbage generation with duplicate schemas being parsed
this PR is a simple fix to enable a cache to be inserted in the reader, so that the cache lookup can replace the parse where there is an exact match already
The shape of the API changes - I leave this to the reviewers to comment, and I am happy to work to their steer, and will generate tests when I have agreement of the approach to this
Verifying this change
(Please pick one of the following options)
I will add tests once the chnages to the API have been agreed. There are many ways that this chnage could be implemented so I dont want to spend th time until the shape can be agreed
Documentation