Skip to content

Support None comparisons for null expressions #1489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timsaucer merged 2 commits into from
Apr 13, 2026
Merged

Support None comparisons for null expressions #1489

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4000b95
Support None comparisons for null expressions
zeel2104 Apr 12, 2026
85e710e
Fold None comparison coverage into relational expr test
zeel2104 Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions python/datafusion/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,8 @@ def __eq__(self, rhs: object) -> Expr:

Accepts either an expression or any valid PyArrow scalar literal value.
"""
if rhs is None:
return self.is_null()
if not isinstance(rhs, Expr):
rhs = Expr.literal(rhs)
return Expr(self.expr.__eq__(rhs.expr))
Expand All @@ -492,6 +494,8 @@ def __ne__(self, rhs: object) -> Expr:

Accepts either an expression or any valid PyArrow scalar literal value.
"""
if rhs is None:
return self.is_not_null()
if not isinstance(rhs, Expr):
rhs = Expr.literal(rhs)
return Expr(self.expr.__ne__(rhs.expr))
Expand Down
18 changes: 18 additions & 0 deletions python/tests/test_expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,24 @@ def test_relational_expr(test_ctx):
assert df.filter(col("a") == "beta").count() == 0


def test_relational_expr_none_uses_null_predicates():
ctx = SessionContext()

batch = pa.RecordBatch.from_arrays(
[
pa.array([1, 2, None]),
pa.array(["alpha", None, "gamma"], type=pa.string_view()),
],
names=["a", "b"],
)
df = ctx.create_dataframe([[batch]], name="batch_with_nulls")

assert df.filter(col("a") == None).count() == 1 # noqa: E711
assert df.filter(col("a") != None).count() == 2 # noqa: E711
assert df.filter(col("b") == None).count() == 1 # noqa: E711
assert df.filter(col("b") != None).count() == 2 # noqa: E711
Copy link
Copy Markdown
Member

@timsaucer timsaucer Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can just update the test_relational_expr to have some null values and incorporate this into the existing test.

Copy link
Copy Markdown
Contributor Author

@zeel2104 zeel2104 Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the tests to fold the None comparison coverage into test_relational_expr and pushed the change. Thanks for the suggestion.



def test_expr_to_variant():
# Taken from https://github.com/apache/datafusion-python/issues/781
from datafusion import SessionContext
Expand Down
Loading