Skip to content

Snowflake: Support dollar quoted comments#1755

Merged
iffyio merged 6 commits intoapache:mainfrom
validio-io:snowflake_dollar_quoted_comment
Mar 15, 2025
Merged

Snowflake: Support dollar quoted comments#1755
iffyio merged 6 commits intoapache:mainfrom
validio-io:snowflake_dollar_quoted_comment

Conversation

@7phs
Copy link
Copy Markdown
Contributor

@7phs 7phs commented Mar 4, 2025

Snowflake supports dollar-quoted comments as string literals when creating tables, views, and their fields.

For example:

CREATE OR REPLACE TEMPORARY VIEW foo.bar.baz (
    "COL_1" COMMENT $$comment 1$$
) COMMENT = $$view comment$$ AS (
    SELECT 1
)

This pull request adds support for this type of comments.

@7phs 7phs changed the title Snowflake: Support dollar quoted comment of table, view and field Snowflake: Support dollar quoted comment when creating tables, views, and their fields Mar 4, 2025
Comment thread src/parser/mod.rs Outdated
Comment thread tests/sqlparser_snowflake.rs Outdated
Comment thread src/dialect/snowflake.rs Outdated
@7phs 7phs requested a review from iffyio March 13, 2025 17:49
Comment thread src/parser/mod.rs Outdated
@7phs 7phs requested a review from iffyio March 14, 2025 16:18
Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @7phs!
cc @alamb

@iffyio iffyio changed the title Snowflake: Support dollar quoted comment when creating tables, views, and their fields Snowflake: Support dollar quoted comments Mar 15, 2025
@iffyio iffyio merged commit 10cf7c1 into apache:main Mar 15, 2025
9 checks passed
@iffyio iffyio deleted the snowflake_dollar_quoted_comment branch March 15, 2025 06:07
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 16, 2025

🚀

ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants