Fix STRAIGHT_JOIN constraint when table alias is absent#1812
Merged
iffyio merged 2 commits intoapache:mainfrom Apr 15, 2025
Merged
Fix STRAIGHT_JOIN constraint when table alias is absent#1812iffyio merged 2 commits intoapache:mainfrom
STRAIGHT_JOIN constraint when table alias is absent#1812iffyio merged 2 commits intoapache:mainfrom
Conversation
iffyio
reviewed
Apr 15, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
Thanks @killertux! Left one minor comment to merge the test cases otherwise this looks good to me
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
iffyio
approved these changes
Apr 15, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
Thanks @killertux!
cc @alamb
iffyio
changed the title
STRAIGHT_JOIN constraint when table alias is absent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1802 was added support for MySQL STRAIGHT_JOIN, but it was not added as a RESERVED_FOR_TABLE_ALIAS. Because of this, it fails to parse queries where we are not using an alias.