Handle missing login in changelog generate script#1823
Merged
alamb merged 1 commit intoapache:mainfrom Apr 28, 2025
Merged
Conversation
Noticed during apache#1822 that the script initially failed due to [this commit](apache@10cf7c1) no longer having the associated GitHub user. Updates the script to skip the username referencing in such cases.
alamb
reviewed
Apr 28, 2025
| for (pull, commit) in pulls: | ||
| url = "https://github.com/{}/pull/{}".format(repo_name, pull.number) | ||
| print("- {} [#{}]({}) ({})".format(pull.title, pull.number, url, commit.author.login)) | ||
| author = f"({commit.author.login})" if commit.author else '' |
alamb
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed during #1822 that the script initially failed due to this
commit no longer having the associated GitHub user.
Updates the script to skip the username referencing in such cases.