Add support for INCLUDE/EXCLUDE NULLS for UNPIVOT#1849
Merged
iffyio merged 3 commits intoapache:mainfrom May 15, 2025
Merged
Conversation
iffyio
reviewed
May 14, 2025
| value: Ident, | ||
| name: Ident, | ||
| columns: Vec<Ident>, | ||
| include_nulls: Option<bool>, |
Contributor
There was a problem hiding this comment.
I'm thinking it would be useful to include a description of this parameter - specifically highlighting that true means include nulls and false means exclude nulls (thinking otherwise at least the latter won't be obvious API wise to a user of the library without reading the code).
Also maybe we can call this property null_treatment similar to e.g. Function vs include_nulls which only covers one possible value naming wise?
Contributor
Author
There was a problem hiding this comment.
Yeah, agree. To not confuse it with null_treatment I add a new one null_inclussion. As I have checked it's used only in UNPIVOT.
Vedin
force-pushed
the
unpivot-improvments
branch
from
79c8d39 to
8e87a2c
Compare
Vedin
force-pushed
the
unpivot-improvments
branch
from
8e87a2c to
e029450
Compare
Vedin
added a commit
to Embucket/datafusion-sqlparser-rs
that referenced
this pull request
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UNPIVOT structure is changed from 2023 and now supports INCLUDE or EXCLUDE NULLS.
Full syntax now looks like:
So, I added this functionality.