Add support for parameter default values in SQL Server#1866
Merged
iffyio merged 1 commit intoapache:mainfrom May 29, 2025
Merged
Add support for parameter default values in SQL Server#1866iffyio merged 1 commit intoapache:mainfrom
iffyio merged 1 commit intoapache:mainfrom
Conversation
iffyio
approved these changes
May 29, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @aharpervc!
cc @alamb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for default values for parameters, as documented here: https://learn.microsoft.com/en-us/sql/t-sql/statements/create-function-transact-sql?view=sql-server-ver17#--default-
The concept of a parameter default value already existed on the
OperateFunctionArgstruct, but was hardcoded toNone. That logic has been updated to conditionally consume=& parse an Expr.Since this is relevant for SQL Server, a new test was added to
sqlparser_mssql.rsaccordingly.