MySQL: [[NOT] ENFORCED] in CHECK constraint#1870
Merged
iffyio merged 3 commits intoapache:mainfrom Jun 7, 2025
Merged
Conversation
iffyio
reviewed
Jun 6, 2025
| self.expect_token(&Token::RParen)?; | ||
| Ok(Some(TableConstraint::Check { name, expr })) | ||
|
|
||
| let enforced = match dialect_of!(self is GenericDialect | MySqlDialect) { |
Contributor
There was a problem hiding this comment.
I think we can have the parser always accept the NOT ENFORCED keywords if they show up in the statement? Otherwise we'd want to turn this into a dialect method instead of using the dialect_of macro but that feels like it might not be worth it in this case
Contributor
Author
There was a problem hiding this comment.
Updated and rebased on main
Add support for MySQL's `[[NOT] ENFORCED]` option for CHECK constraints. docs: https://dev.mysql.com/doc/refman/8.4/en/create-table.html
MohamedAbdeen21
force-pushed
the
mysql-enforced-constraint
branch
from
927aefc to
20646fc
Compare
iffyio
approved these changes
Jun 7, 2025
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @MohamedAbdeen21!
cc @alamb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for MySQL's
[[NOT] ENFORCED]option for CHECK constraints.docs: https://dev.mysql.com/doc/refman/8.4/en/create-table.html