Merged
Conversation
iffyio
reviewed
Jun 6, 2025
Contributor
iffyio
left a comment
There was a problem hiding this comment.
Thanks @eliaperantoni! The changes look reasonable to me, left a minor comment
iffyio
approved these changes
Jun 6, 2025
Contributor
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks again @eliaperantoni!
cc @alamb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a
Expr::Caseimplementation ofSpannedwould ignore theCASE .. ENDkeywords. ie.Because the only stored locations would be those of the
Identinside theCASEexpression.This PR attaches two
AttachedTokento the AST node, one forCASEand one forEND, so thatSpanned::spannow returns the whole range. This was done to follow the footsteps of theSELECTimplementation, which also stores anAttachedTokenfor theSELECTkeyword. Also added a test for this.Closes #1874.