Conversation
|
@iffyio please take a look |
iffyio
left a comment
There was a problem hiding this comment.
Thanks @osipovartem! Left a minor comment otherwise the changes look good to me
| /// Parse a boolean string | ||
| pub fn parse_boolean_string(&mut self) -> Result<bool, ParserError> { | ||
| match self.parse_one_of_keywords(&[Keyword::TRUE, Keyword::FALSE]) { | ||
| Some(Keyword::TRUE) => Ok(true), | ||
| Some(Keyword::FALSE) => Ok(false), | ||
| _ => self.expected("TRUE or FALSE", self.peek_token()), | ||
| } | ||
| } |
There was a problem hiding this comment.
oh this looks like its only used once, can we inline it instead?
There was a problem hiding this comment.
This will be used in the next PR
related to #1982
There was a problem hiding this comment.
Ah I see, but I think we can inline it in this PR and if it ends up being used in the next PR we can break it out into a function. Also heads up for the function we would want to make it either private or pub(crate) visibility wise instead of pub
There was a problem hiding this comment.
Replaced duplicated code by parse_boolean_string call
There was a problem hiding this comment.
Please review again
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @osipovartem!
cc @alamb
https://docs.snowflake.com/en/sql-reference/sql/create-database
Added support for
Closes #1938