Skip to content

Allow wilrdacrd for all SEMANTIC_VIEW types #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iffyio merged 1 commit into from
Aug 29, 2025
Merged

Allow wilrdacrd for all SEMANTIC_VIEW types #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/parser/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13951,7 +13951,7 @@ impl<'a> Parser<'a> {
"DIMENSIONS clause can only be specified once".to_string(),
));
}
dimensions = self.parse_comma_separated(Parser::parse_expr)?;
dimensions = self.parse_comma_separated(Parser::parse_wildcard_expr)?;
} else if self.parse_keyword(Keyword::METRICS) {
if !metrics.is_empty() {
return Err(ParserError::ParserError(
Expand All @@ -13965,7 +13965,7 @@ impl<'a> Parser<'a> {
"FACTS clause can only be specified once".to_string(),
));
}
facts = self.parse_comma_separated(Parser::parse_expr)?;
facts = self.parse_comma_separated(Parser::parse_wildcard_expr)?;
} else if self.parse_keyword(Keyword::WHERE) {
if where_clause.is_some() {
return Err(ParserError::ParserError(
Expand Down
5 changes: 5 additions & 0 deletions tests/sqlparser_common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16952,6 +16952,11 @@ fn test_parse_semantic_view_table_factor() {
None,
),
("SELECT * FROM SEMANTIC_VIEW(model METRICS orders.*)", None),
("SELECT * FROM SEMANTIC_VIEW(model FACTS fact.*)", None),
(
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim.* METRICS orders.*)",
None,
),
// We can parse in any order but will always produce a result in a fixed order.
(
"SELECT * FROM SEMANTIC_VIEW(model WHERE x > 0 DIMENSIONS dim1)",
Expand Down