Conversation
roeap
changed the title
| INTERSECTION, | ||
| INTERVAL, | ||
| INTO, | ||
| INVENTORY, |
There was a problem hiding this comment.
Can we add test cases to demonstrate the added functionality?
There was a problem hiding this comment.
Certainly @iffyio. I had been looking through the code for existing tests, but to no avail. So unsure if I should add some cases to the tokenizer tests or in the parser module?
Or is there a more obvious place I am missing?
There was a problem hiding this comment.
We can probably extend this test to include new scenarios?
There was a problem hiding this comment.
@iffyio - your hint got me to dive a bit deeper into the codebase. Unfortunately the Redhsift and Databricks VACUUM commands are quite different.
That said, would you accept a PR where I extend this a bit, add a custom statement parser option the databricks dialect and a VacuumDatabricks Statement variant?
There was a problem hiding this comment.
Ah yeah it should possible to support databricks' variant of the vacuum command. But we tend to not have dialect specific statements so that it'll likely need to be part of the existing Statement::Vacuum variant in this case, being extended to support the new options
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
2 participants
The LITE and INVENTORY keywords are used in the delta VACUUM command, would be great if we could add it.
The SHALLOW keyword is used in shallow clones of delta tables.