Skip to content

Correctly tokenize nested comments in Databricks, ClickHouse, and ANSI#2044

Merged
iffyio merged 5 commits intoapache:mainfrom
jmhain:nested-comments
Sep 26, 2025
Merged

Correctly tokenize nested comments in Databricks, ClickHouse, and ANSI#2044
iffyio merged 5 commits intoapache:mainfrom
jmhain:nested-comments

Conversation

@jmhain
Copy link
Copy Markdown
Contributor

@jmhain jmhain commented Sep 24, 2025

No description provided.

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmhain! Changes look good to me overall, left some minor suggestions

Comment thread src/dialect/ansi.rs Outdated
Comment thread src/dialect/clickhouse.rs Outdated
Comment thread src/dialect/databricks.rs Outdated
@jmhain
Copy link
Copy Markdown
Contributor Author

jmhain commented Sep 25, 2025

Updated per suggestions. Thanks for the review @iffyio!

Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again @jmhain!

@iffyio iffyio added this pull request to the merge queue Sep 26, 2025
Merged via the queue into apache:main with commit c099883 Sep 26, 2025
10 checks passed
@jmhain jmhain deleted the nested-comments branch September 26, 2025 16:37
@alamb alamb changed the title Correctly tokenize nested comments in Databricks, Clickhouse, and ANSI Correctly tokenize nested comments in Databricks, ClickHouse, and ANSI Dec 2, 2025
ayman-sigma pushed a commit to sigmacomputing/sqlparser-rs that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants