perf: remove unnecessary string clone in maybe_concat_string_literal#2173
Merged
iffyio merged 1 commit intoapache:mainfrom Jan 23, 2026
Merged
perf: remove unnecessary string clone in maybe_concat_string_literal#2173iffyio merged 1 commit intoapache:mainfrom
iffyio merged 1 commit intoapache:mainfrom
Conversation
Replace `s.clone().as_str()` with just `s` since `s` is already a `&String` which can be passed directly to `push_str()`. This removes one String allocation per concatenated string literal when parsing SQL with adjacent string literals like 'foo' 'bar'. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
…pache#2173) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
fmguerreiro
pushed a commit
to fmguerreiro/datafusion-sqlparser-rs
that referenced
this pull request
Feb 20, 2026
…pache#2173) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove an unnecessary
String::clone()inmaybe_concat_string_literal().Changes
Since
sis already a&String(from theref spattern match), it can be passed directly topush_str()which accepts&str. The deref coercion handles the conversion automatically.Impact
This removes one heap allocation per concatenated string literal when parsing SQL with adjacent string literals like:
Small change but in the spirit of avoiding unnecessary allocations in the parser hot path.
Test plan
cargo clippypasses🤖 Generated with Claude Code