Implement core::error::Error for ParserError and TokenizerError#2189
Merged
iffyio merged 2 commits intoapache:mainfrom Feb 2, 2026
Merged
Implement core::error::Error for ParserError and TokenizerError#2189iffyio merged 2 commits intoapache:mainfrom
core::error::Error for ParserError and TokenizerError#2189iffyio merged 2 commits intoapache:mainfrom
Conversation
iffyio
changed the title
core::error::Error for ParserError and TokenizerError
iffyio
approved these changes
Feb 2, 2026
Contributor
iffyio
left a comment
iffyio
left a comment
There was a problem hiding this comment.
LGTM! Thanks @LucaCappelletti94!
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Feb 3, 2026
fmguerreiro
pushed a commit
to fmguerreiro/datafusion-sqlparser-rs
that referenced
this pull request
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates
ParserErrorandTokenizerErrorto implementcore::error::Errorinstead ofstd::error::Error.This change enables the Error trait implementation for these types in no_std environments unconditionally, removing the need for
#[cfg(feature = "std")]guards.