Skip to content

Added missing derives to dialect marker structs#2191

Merged
iffyio merged 4 commits intoapache:mainfrom
LucaCappelletti94:dialect-derives
Feb 6, 2026
Merged

Added missing derives to dialect marker structs#2191
iffyio merged 4 commits intoapache:mainfrom
LucaCappelletti94:dialect-derives

Conversation

@LucaCappelletti94
Copy link
Copy Markdown
Contributor

This PR adds common derive macros to all dialect structs for consistency and improved usability.

Changes

Added the following derives to all dialect structs:

  • Clone
  • Copy
  • Default
  • PartialEq
  • Eq
  • Hash
  • PartialOrd
  • Ord
  • serde::Serialize (when serde feature is enabled)
  • serde::Deserialize (when serde feature is enabled)

Closes issue #2190

@LucaCappelletti94 LucaCappelletti94 marked this pull request as ready for review February 2, 2026 10:27
Copy link
Copy Markdown
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @LucaCappelletti94!

@iffyio iffyio added this pull request to the merge queue Feb 6, 2026
Merged via the queue into apache:main with commit bc55b37 Feb 6, 2026
10 checks passed
fmguerreiro pushed a commit to fmguerreiro/datafusion-sqlparser-rs that referenced this pull request Feb 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants