Skip to content

Commit 17b1bd4

Browse files
committed
changed code as your suggestions
1 parent 8725d5c commit 17b1bd4

1 file changed

Lines changed: 9 additions & 18 deletions

File tree

datafusion/optimizer/src/eliminate_duplicated_expr.rs

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -85,24 +85,15 @@ impl OptimizerRule for EliminateDuplicatedExpr {
8585
&sort_expr_names,
8686
);
8787

88-
let (unique_exprs, fd_transformed) =
89-
if let Some(required_indices) = required_indices {
90-
if required_indices.len() != unique_exprs.len() {
91-
(
92-
required_indices
93-
.into_iter()
94-
.map(|idx| unique_exprs[idx].clone())
95-
.collect(),
96-
true,
97-
)
98-
} else {
99-
(unique_exprs, false)
100-
}
101-
} else {
102-
(unique_exprs, false)
103-
};
104-
105-
let transformed = if len != unique_exprs.len() || fd_transformed {
88+
let unique_exprs = match required_indices {
89+
Some(indices) if indices.len() < unique_exprs.len() => indices
90+
.into_iter()
91+
.map(|idx| unique_exprs[idx].clone())
92+
.collect(),
93+
_ => unique_exprs,
94+
};
95+
96+
let transformed = if len != unique_exprs.len() {
10697
Transformed::yes
10798
} else {
10899
Transformed::no

0 commit comments

Comments
 (0)