[docs] add sql example to timestamp/datetime docs for time zone #21082
Merged
berkaysynnada merged 2 commits intoapache:mainfrom Apr 2, 2026
Merged
Conversation
github-actions
Bot
added
documentation
buraksenn
force-pushed
the
add-sql-examples-to-date-time-documentation
branch
from
f76f64f to
b446c28
Compare
buraksenn
force-pushed
the
add-sql-examples-to-date-time-documentation
branch
from
b446c28 to
27832b9
Compare
Contributor
Author
|
Can you review this if you've time @berkaysynnada? |
berkaysynnada
approved these changes
Apr 2, 2026
Contributor
berkaysynnada
left a comment
berkaysynnada
left a comment
There was a problem hiding this comment.
lgtm, thanks @buraksenn
Might be worth double-checking a couple of things:
current_time(): Europe/London in December should be UTC+0, so the +1h offset might not hold, so it could be worth picking a timezone with a clear winter offset.- now(): the "Z" suffix after switching to America/New_York might be incorrect since "Z" means UTC, but the return type carries the session timezone. Might want to run it locally to confirm what actually gets printed
Contributor
Author
I've run the cli and verified each now. There was some mistakes that I've missed thanks @berkaysynnada |
zhuqi-lucas
pushed a commit
to zhuqi-lucas/arrow-datafusion
that referenced
this pull request
Apr 4, 2026
…he#21082) ## Which issue does this PR close? - Closes apache#19104. ## Rationale for this change apache#19104 explains but some datetime functions respect `execution.time_zone` config but there are no SQL examples for them. This PR adds it and also missing sql example for `date_part`, `extract` and `date_trunc` ## What changes are included in this PR? sql example changes and generated doc ## Are these changes tested? ## Are there any user-facing changes?
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
…he#21082) ## Which issue does this PR close? - Closes apache#19104. ## Rationale for this change apache#19104 explains but some datetime functions respect `execution.time_zone` config but there are no SQL examples for them. This PR adds it and also missing sql example for `date_part`, `extract` and `date_trunc` ## What changes are included in this PR? sql example changes and generated doc ## Are these changes tested? ## Are there any user-facing changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
#19104 explains but some datetime functions respect
execution.time_zoneconfig but there are no SQL examples for them. This PR adds it and also missing sql example fordate_part,extractanddate_truncWhat changes are included in this PR?
sql example changes and generated doc
Are these changes tested?
Are there any user-facing changes?