Skip to content

fix: date overflow panic#21233

Merged
alamb merged 4 commits intoapache:mainfrom
haohuaijin:data-painc
Mar 31, 2026
Merged

fix: date overflow panic#21233
alamb merged 4 commits intoapache:mainfrom
haohuaijin:data-painc

Conversation

@haohuaijin
Copy link
Copy Markdown
Contributor

@haohuaijin haohuaijin commented Mar 29, 2026 •
edited
Loading

Which issue does this PR close?

Rationale for this change

What changes are included in this PR?

handle Date32 and Date64 in get_extreme_value function

Are these changes tested?

yes, add test case

Are there any user-facing changes?

@github-actions github-actions Bot added logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt) labels Mar 29, 2026
xiedeyantu
xiedeyantu approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@xiedeyantu xiedeyantu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

xudong963
xudong963 reviewed Mar 30, 2026
View reviewed changes
Comment thread datafusion/sqllogictest/test_files/datetime/arith_date_interval.slt
@haohuaijin
Copy link
Copy Markdown
Contributor Author

haohuaijin commented Mar 30, 2026

the test case failed, but look like unrelated to my change.

@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 30, 2026

the test case failed, but look like unrelated to my change.

I think it was fixed by @mbutrovich here

I merged you PR up from main to get the latest code

Thank you

@alamb alamb added this pull request to the merge queue Mar 31, 2026
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Mar 31, 2026 •
edited
Loading

Thanks @xudong963 and @xiedeyantu and @haohuaijin

Merged via the queue into apache:main with commit e74b83a Mar 31, 2026
34 checks passed
@alamb alamb added the bug Something isn't working label Mar 31, 2026
@haohuaijin haohuaijin deleted the data-painc branch March 31, 2026 23:40
Rich-T-kid pushed a commit to Rich-T-kid/datafusion that referenced this pull request Apr 21, 2026
@haohuaijin @alamb @Rich-T-kid
fix: date overflow panic (apache#21233)
76cfe19 
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes apache#21234

## Rationale for this change

- see apache#21234

## What changes are included in this PR?

handle Date32 and Date64 in `get_extreme_value` function

## Are these changes tested?

yes, add test case

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xudong963 xudong963 xudong963 approved these changes

+1 more reviewer

@xiedeyantu xiedeyantu xiedeyantu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working logical-expr Logical plan and expressions sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

date type panic when overflow

4 participants

@haohuaijin @alamb @xudong963 @xiedeyantu