Skip to content

chore: create benches small ints for count_distinct #21521

Merged
alamb merged 2 commits intoapache:mainfrom
coderfender:add_benches_count_distinct_approx_distinct
Apr 9, 2026
Merged

chore: create benches small ints for count_distinct #21521
alamb merged 2 commits intoapache:mainfrom
coderfender:add_benches_count_distinct_approx_distinct

Conversation

@coderfender
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions Bot added the functions Changes to functions implementation label Apr 9, 2026
@coderfender
Copy link
Copy Markdown
Contributor Author

coderfender commented Apr 9, 2026

@alamb , pulled out benches into separate PR for better evaluating : #21456

@coderfender coderfender changed the title chore : create benches small ints for count_distinct chore: create benches small ints for count_distinct Apr 9, 2026
@alamb alamb added this pull request to the merge queue Apr 9, 2026
@alamb
Copy link
Copy Markdown
Contributor

alamb commented Apr 9, 2026

Thank you @coderfender

Merged via the queue into apache:main with commit fbdf770 Apr 9, 2026
35 checks passed
Rich-T-kid pushed a commit to Rich-T-kid/datafusion that referenced this pull request Apr 21, 2026
## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Closes #.

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

functions Changes to functions implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants