chore: add count distinct group benchmarks#21575
Merged
alamb merged 13 commits intoapache:mainfrom Apr 19, 2026
Merged
Conversation
coderfender
force-pushed
the
add_group_benchmarks_count_distinct
branch
from
9413a74 to
bacee66
Compare
coderfender
force-pushed
the
add_group_benchmarks_count_distinct
branch
from
3abdd0d to
45a19b0
Compare
Contributor
Author
|
@Dandandan , I plan to add benches to help better evaluate group accumulators along with direct clickbench / TPCH queries for implementing group accumulators . Please take a look whenever you get a chance |
Dandandan
approved these changes
Apr 14, 2026
martin-g
reviewed
Apr 14, 2026
coderfender
force-pushed
the
add_group_benchmarks_count_distinct
branch
from
a65b849 to
17dd86b
Compare
martin-g
approved these changes
Apr 16, 2026
martin-g
reviewed
Apr 16, 2026
Rich-T-kid
pushed a commit
to Rich-T-kid/datafusion
that referenced
this pull request
Apr 21, 2026
## Which issue does this PR close? Add benchmarks for group accumulators to test : apache#21561 The implementation forks out based on `is_groups_accumulator_supported` function call. Once this is merged , we should be able to evaluate group accumulators on count distinct expr <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
lyne7-sc
pushed a commit
to lyne7-sc/datafusion
that referenced
this pull request
Apr 22, 2026
…ache#21561) ## Which issue does this PR close? Evaluate perf with group accumulators for count distinct <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes apache#123` indicates that this PR will close issue apache#123. --> - Closes #. Related : apache#21575 benchmark PR ## Rationale for this change <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Add benchmarks for group accumulators to test : #21561
The implementation forks out based on
is_groups_accumulator_supportedfunction call. Once this is merged , we should be able to evaluate group accumulators on count distinct exprRationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?