fix: resolve HashJoin deadlock with dynamic filtering and empty partitions#21631
Closed
RatulDawar wants to merge 1 commit intoapache:mainfrom
Closed
fix: resolve HashJoin deadlock with dynamic filtering and empty partitions#21631RatulDawar wants to merge 1 commit intoapache:mainfrom
RatulDawar wants to merge 1 commit intoapache:mainfrom
Conversation
36e5098 to
d075e5f
Compare
…tions Defer short-circuiting to Completed state for empty partitions when dynamic filtering is enabled. This ensures all partitions participate in the SharedBuildAccumulator barrier synchronization before finishing. Made-with: Cursor
d075e5f to
7bf5565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a deadlock in
HashJoinExecthat occurs when dynamic filtering is enabled and some partitions have an empty build side.The Issue
When dynamic filtering is enabled, all partitions must report their build-side data to a
SharedBuildAccumulatorand wait on atokio::sync::Barrier. However, a short-circuit optimization was causing partitions with empty build sides to immediately transition to theCompletedstate, skipping the reporting and the barrier. This left non-empty partitions waiting indefinitely for the missing partitions to reach the barrier.The Fix
The fix ensures that if a
SharedBuildAccumulatoris present, even empty partitions must proceed to theWaitPartitionBoundsReportstate. This ensures they participate in the barrier synchronization before the short-circuit toCompletedis allowed to happen.Test Plan
Reproduced the issue using TPC-H Query 18 with 24 partitions (
DATAFUSION_EXECUTION_TARGET_PARTITIONS=24).Made with Cursor