perf(substr_index): speed up scalar and Utf8View#21754
Merged
alamb merged 2 commits intoapache:mainfrom Apr 25, 2026
Merged
Conversation
Contributor
Author
|
cc @neilconway since you are working on this area. |
Contributor
|
@kumarUjjawal Thanks for working on this! Can you post some benchmark data, please? |
neilconway
reviewed
Apr 21, 2026
| count_array, | ||
| GenericStringBuilder::<i32>::with_capacity( | ||
| string_array.len(), | ||
| string_array.value_data().len(), |
Contributor
There was a problem hiding this comment.
Here and below, this over-allocates the buffer capacity for sliced arrays.
Contributor
Author
|
neilconway
approved these changes
Apr 22, 2026
Contributor
Author
|
Thanks @neilconway |
alamb
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
substr_indexis part of the Utf8View epic. This function was still missing the Utf8View optimization path, and it also did extra work when delimiter and count were constant scalars.This PR adds the same kind of optimization used in similar string work and includes benchmark coverage.
What changes are included in this PR?
Utf8View.Utf8Viewpath forsubstr_index.Utf8Viewtype and value results.Utf8Viewarrays, and the unchanged original-view case.Utf8,Utf8View, array arguments, scalar delimiter/count, and positive and negative counts.Are these changes tested?
Yes
Are there any user-facing changes?
No