feat: add prefer_partial_sort config to enable PartialSortExec for bo…#21805
Open
SubhamSinghal wants to merge 3 commits intoapache:mainfrom
Open
feat: add prefer_partial_sort config to enable PartialSortExec for bo…#21805SubhamSinghal wants to merge 3 commits intoapache:mainfrom
SubhamSinghal wants to merge 3 commits intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
datafusion.optimizer.prefer_partial_sort(defaultfalse) inOptimizerOptionsreplace_with_partial_sortinEnforceSortingnow acceptsConfigOptionsand allows bounded inputswhen the config is enabled
enforce_sorting.rs— bounded input with config enabled (expectsPartialSortExec), andbounded input with no common prefix (stays
SortExec)(a, b), ORDER BYa, b, c(a), ORDER BYa, b, c(a, b, c), ORDER BYa, b, c, dwe can enable
datafusion.optimizer.prefer_partial_sortby default after adding spill support.Are these changes tested?
Yes.
enforce_sorting.rs(bounded with config, no-prefix with config)partial_sort_bounded.sltwith 3 scenarios covering correctness, EXPLAIN plans, LIMIT, and config resetfalse, so no behavior change)Are there any user-facing changes?
Yes — a new configuration option: