branch-4.1: [fix](insert) fix INSERT job statistics lost in show load after FE restart #62331#62546
Open
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Open
branch-4.1: [fix](insert) fix INSERT job statistics lost in show load after FE restart #62331#62546github-actions[bot] wants to merge 1 commit intobranch-4.1from
github-actions[bot] wants to merge 1 commit intobranch-4.1from
Conversation
…start (#62331) ## Problem After a FE restart, `SHOW LOAD` for finished INSERT jobs shows all-zero `JobDetails` (`ScannedRows`, `LoadBytes`, etc.), even though the values were correct before the restart. ## Fix **`InsertLoadJob`** - Add `@SerializedName("jdj") private String jobDetailsJson` to capture a JSON snapshot of `loadStatistic` at the moment the job finishes. - In `setJobProperties()` (called when the job transitions to FINISHED/CANCELLED), snapshot `loadStatistic.toJson()` into `jobDetailsJson`. - Override `getJobDetailsJson()` to return the persisted snapshot when available, falling back to the live `loadStatistic` during execution. **`LoadJob`** - Extract `protected String getJobDetailsJson()` (defaults to `loadStatistic.toJson()`) so subclasses can override the stats source used by `getShowInfoUnderLock()`. **`OlapInsertExecutor`** - Remove the `!Config.enable_nereids_load` guard in `afterExec()` so that `recordFinishedLoadJob` is always called when `jobId != -1`. This ensures the job is persisted to the edit log and its statistics are captured regardless of the config value. ## Test Added `test_insert_statistic_after_fe_restart` docker regression test that: 1. Inserts rows via `INSERT INTO ... SELECT` 2. Reads and records `JobDetails` from `SHOW LOAD` 3. Restarts FE 4. Asserts `ScannedRows`, `LoadBytes`, `FileNumber`, `FileSize` are unchanged after restart
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #62331