feat: persist __time min/max in V10 ProjectionMetadata#19398
Open
clintropolis wants to merge 2 commits intoapache:masterfrom
Open
feat: persist __time min/max in V10 ProjectionMetadata#19398clintropolis wants to merge 2 commits intoapache:masterfrom
clintropolis wants to merge 2 commits intoapache:masterfrom
Conversation
changes: * add nullable `minTime`/`maxTime` Long fields to `ProjectionMetadata` alongside the existing `numRows` * track min/max __time in `IndexMergerBase.mergeIndexesAndWriteColumns` via `timestampSelector.getLong()` on each row; surface via `IndexMergeResult` (null when zero rows are walked) * `IndexMergerV10` wires the merge result's values into the base-table `ProjectionMetadata`; aggregate projections leave the new fields null for now, though we can easily add this in future work if useful * tracking is done regardless of segment sort order, non-time-sorted segments (`DimensionsSpec.forceSegmentSortByTime` = false) also store these values accurately (just with less utility since we can't use the information to skip rows, though we could use them to know if there are no rows within the time range) * write-side only: fields are persisted but not yet consumed. A follow-up will add a partial V10-aware `TimeBoundaryInspector` that reads them
FrankChen021
reviewed
May 4, 2026
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
This is an automated review by Codex GPT-5
FrankChen021
reviewed
May 5, 2026
Member
FrankChen021
left a comment
FrankChen021
left a comment
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
This is an automated review by Codex GPT-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changes:
minTime/maxTimeLong fields toProjectionMetadataalongside the existingnumRowsIndexMergerBase.mergeIndexesAndWriteColumnsviatimestampSelector.getLong()on each row; surface viaIndexMergeResult(null when zero rows are walked)IndexMergerV10wires the merge result's values into the base-tableProjectionMetadata; aggregate projections leave the new fields null for now, though we can easily add this in future work if usefulDimensionsSpec.forceSegmentSortByTime = false) also store these values accurately (just with less utility since we can't use the information to skip rows, though we could use them to know if there are no rows within the time range)TimeBoundaryInspectorthat reads them