[VL] Ignore null values when copy velox string buffer to arrow#11944
Merged
FelixYBW merged 2 commits intoapache:mainfrom Apr 17, 2026
Merged
[VL] Ignore null values when copy velox string buffer to arrow#11944FelixYBW merged 2 commits intoapache:mainfrom
FelixYBW merged 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
Retest this please |
Member
|
@wankunde thanks for the fix, would you please also add a unit test to guard on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Bug fix for VeloxHashShuffleWriter.
Description:
VeloxHashShuffleWriter::write()method will try to convert the input velox flat vectors into Arrow buffer.VeloxHashShuffleWritercalculates the total size of all input StringViews, and initializes the Arrow buffer accordingly.Test logs in our productions:
How was this patch tested?
Tested in out production environment.
Was this patch authored or co-authored using generative AI tooling?
No