Skip to content

Add analyzer and code fix for public types in Lucene.Net.Support, #1100 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulirwin merged 10 commits into from
Oct 4, 2025
Merged

Add analyzer and code fix for public types in Lucene.Net.Support, #1100 #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
fa11b30
Add analyzer for public types in Support namespace
paulirwin Mar 8, 2025
3c8150c
Remove migrated resource for code fix title
paulirwin Sep 28, 2025
2c17fe9
Remove .globalconfig file
paulirwin Sep 29, 2025
5f7624f
Upgrade RAT to 0.16.1, clean up line endings after running
paulirwin Sep 30, 2025
a091021
Fix casing of code fix provider name
paulirwin Sep 30, 2025
729e2d5
Fix code fix with partial classes
paulirwin Sep 30, 2025
fe58038
Revert Markdown changes and exclude from RAT
paulirwin Sep 30, 2025
13a7c86
RAT exclude only AnalyzerReleases files; fix warning about AnalyzerRe…
paulirwin Sep 30, 2025
ca536ff
Use MajorMinorVersion instead of Version
paulirwin Sep 30, 2025
bd72042
Fix code fix to preserve license headers and comments
paulirwin Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .rat-excludes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@ _site/*

release-build-outcomes\.svg
release-workflow\.svg

# Exclude markdown files
.*\.md
Comment thread
paulirwin marked this conversation as resolved.
Outdated
19 changes: 0 additions & 19 deletions docs/images/release-build-outcomes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,3 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

This markup can be edited and converted to .svg or .png here:
https://www.mermaidchart.com/app/projects/95759d78-db93-499c-ad66-0e3f698ba88c/diagrams/31dbd6bc-7ec8-4583-a456-55e3fe3f6cfc/version/v0.1/edit

Expand Down
19 changes: 0 additions & 19 deletions docs/images/release-workflow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,3 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

This markup can be edited and converted to .svg or .png here:
https://www.mermaidchart.com/app/projects/95759d78-db93-499c-ad66-0e3f698ba88c/diagrams/35faa26e-5ccf-4433-962e-32f20496471c/version/v0.1/edit

Expand Down
31 changes: 6 additions & 25 deletions src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Shipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,11 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

## Release 1.0.0-alpha.6

Check warning on line 1 in src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Shipped.md

View workflow job for this annotation

GitHub Actions / build 

Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header '## Release 1.0.0-alpha.6' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md)

Check warning on line 1 in src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Shipped.md

View workflow job for this annotation

GitHub Actions / build 

Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header '## Release 1.0.0-alpha.6' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md)

Check warning on line 1 in src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Shipped.md

View workflow job for this annotation

GitHub Actions / build 

Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header '## Release 1.0.0-alpha.6' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md)

Check warning on line 1 in src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Shipped.md

View workflow job for this annotation

GitHub Actions / build 

Analyzer release file 'AnalyzerReleases.Shipped.md' has a missing or invalid release header '## Release 1.0.0-alpha.6' (https://github.com/dotnet/roslyn-analyzers/blob/main/src/Microsoft.CodeAnalysis.Analyzers/ReleaseTrackingAnalyzers.Help.md)

### New Rules

Rule ID | Category | Severity | Notes
Rule ID | Category | Severity | Notes
---------------|----------|----------|-----------------------------------------------------------------------------------------------------------------------------------------------------------
LuceneDev1000 | Design | Warning | Floating point types should not be compared for exact equality
LuceneDev1001 | Design | Warning | Floating point types should be formatted with J2N methods
LuceneDev1002 | Design | Warning | Floating point type arithmetic needs to be checked
LuceneDev1003 | Design | Warning | Method parameters that accept array types should be analyzed to determine whether they are better suited to be ref or out parameters
LuceneDev1004 | Design | Warning | Methods that return array types should be analyzed to determine whether they are better suited to be one or more out parameters or to return a ValueTuple
LuceneDev1000 | Design | Warning | Floating point types should not be compared for exact equality
LuceneDev1001 | Design | Warning | Floating point types should be formatted with J2N methods
LuceneDev1002 | Design | Warning | Floating point type arithmetic needs to be checked
LuceneDev1003 | Design | Warning | Method parameters that accept array types should be analyzed to determine whether they are better suited to be ref or out parameters
LuceneDev1004 | Design | Warning | Methods that return array types should be analyzed to determine whether they are better suited to be one or more out parameters or to return a ValueTuple
19 changes: 0 additions & 19 deletions src/Lucene.Net.CodeAnalysis.Dev/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,3 @@
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->

### New Rules

Rule ID | Category | Severity | Notes
Expand Down