[ISSUE #10017] Validate commitlog offset in recoverAbnormally to prevent processing …#10018
Merged
RongtongJin merged 3 commits intoapache:developfrom Jan 20, 2026
Merged
Conversation
added 3 commits
January 16, 2026 17:26
…old file data that passes CRC checks Change-Id: If4b1881f82d26ce8d374472d73ec9ce3d51ba643
Change-Id: Iac9afbb8b3ffb03fa15890decaf502afbfa44cf9
guyinyou
force-pushed
the
dev_optimize_recoverAbnormally
branch
from
79b5b89 to
e909eed
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10018 +/- ##
=============================================
- Coverage 48.89% 48.87% -0.03%
- Complexity 12811 13321 +510
=============================================
Files 1327 1373 +46
Lines 96537 99694 +3157
Branches 12457 12887 +430
=============================================
+ Hits 47201 48722 +1521
- Misses 43582 45041 +1459
- Partials 5754 5931 +177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RongtongJin
approved these changes
Jan 20, 2026
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
Feb 10, 2026
…o prevent processing … (apache#10018) * validate commitlog offset in recoverAbnormally to prevent processing old file data that passes CRC checks Change-Id: If4b1881f82d26ce8d374472d73ec9ce3d51ba643 * fix Change-Id: Idc4bf7ec476cc9b6529619c2aa9afd6a980b819c * add checkCommitLogOffsetOnRecover in MessageStoreConfig Change-Id: Iac9afbb8b3ffb03fa15890decaf502afbfa44cf9 --------- Co-authored-by: guyinyou <guyinyou.gyy@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…old file data that passes CRC checks
Change-Id: If4b1881f82d26ce8d374472d73ec9ce3d51ba643
Which Issue(s) This PR Fixes
Fixes #10017
Brief Description
How Did You Test This Change?