Refactor/issue#10009 add null-check log and Convert internal-only public classes to inner classes #10027
Closed
sinberCS wants to merge 5 commits intoapache:developfrom
Closed
Refactor/issue#10009 add null-check log and Convert internal-only public classes to inner classes #10027sinberCS wants to merge 5 commits intoapache:developfrom
sinberCS wants to merge 5 commits intoapache:developfrom
Conversation
Change-Id: Ia2e901e6c59b09fc4e078785f93997812b49bfd5
feature(workflow): add ai advisor for new issues
…sses and add null-check log Change-Id: Icad60dc7a4b43bebd91c7f1d981a783f9c613e69
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #10027 +/- ##
=============================================
+ Coverage 48.41% 48.91% +0.50%
- Complexity 12255 13337 +1082
=============================================
Files 1314 1373 +59
Lines 93668 99685 +6017
Branches 12011 12885 +874
=============================================
+ Hits 45347 48764 +3417
- Misses 42733 45004 +2271
- Partials 5588 5917 +329 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #10009 (comment)
Brief Description
Although the NPE (NullPointerException) issue mentioned in the issue report shouldn't occur under theoretical circumstances.
For defensive programming purposes, I added a null check at the specified location and changed the internal-only public class to an inner class.I added a null check at the specified location and changed the internal-only public class to an inner class.