Skip to content

[ISSUE #10159] Fix unstable tests in DefaultMQLitePullConsumerWithTraceTest #10160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lizhimins merged 4 commits into from
Mar 13, 2026
Merged

[ISSUE #10159] Fix unstable tests in DefaultMQLitePullConsumerWithTraceTest #10160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c8cb0a
[ISSUE #10159] Fix unstable tests in DefaultMQLitePullConsumerWithTra…
yx9o Mar 9, 2026
6c7e980
Update
yx9o Mar 11, 2026
c5a53df
Update
yx9o Mar 12, 2026
4d4a467
Update
yx9o Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 83 additions & 19 deletions ...rc/test/java/org/apache/rocketmq/client/trace/DefaultMQLitePullConsumerWithTraceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
import java.util.Set;
import java.util.concurrent.ConcurrentMap;
import org.apache.commons.lang3.reflect.FieldUtils;
import org.apache.rocketmq.client.ClientConfig;
import org.apache.rocketmq.client.consumer.DefaultLitePullConsumer;
import org.apache.rocketmq.client.consumer.PullCallback;
import org.apache.rocketmq.client.consumer.PullResult;
Expand Down Expand Up @@ -60,13 +59,13 @@
import org.apache.rocketmq.remoting.protocol.route.BrokerData;
import org.apache.rocketmq.remoting.protocol.route.QueueData;
import org.apache.rocketmq.remoting.protocol.route.TopicRouteData;
import org.junit.After;
import org.junit.Assert;
import org.junit.Before;
import org.junit.BeforeClass;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.Spy;
import org.mockito.invocation.InvocationOnMock;
import org.mockito.junit.MockitoJUnitRunner;
import org.mockito.stubbing.Answer;
Expand All @@ -78,14 +77,16 @@
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.nullable;
import static org.mockito.Mockito.doReturn;
import static org.mockito.Mockito.lenient;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.when;

@RunWith(MockitoJUnitRunner.class)
public class DefaultMQLitePullConsumerWithTraceTest {

@Spy
private MQClientInstance mQClientFactory = MQClientManager.getInstance().getOrCreateMQClientInstance(new ClientConfig());
private MQClientInstance mQClientFactory;
private MQClientInstance mqClientInstance;
private MQClientInstance traceMqClientInstance;

@Mock
private MQClientAPIImpl mQClientAPIImpl;
Expand All @@ -111,12 +112,45 @@ public static void setUpEnv() {

@Before
public void init() throws Exception {
Field field = MQClientInstance.class.getDeclaredField("rebalanceService");
field.setAccessible(true);
RebalanceService rebalanceService = (RebalanceService) field.get(mQClientFactory);
field = RebalanceService.class.getDeclaredField("waitInterval");
field.setAccessible(true);
field.set(rebalanceService, 100);
ConcurrentMap<String, MQClientInstance> factoryTable =
(ConcurrentMap<String, MQClientInstance>) FieldUtils.readDeclaredField(
MQClientManager.getInstance(), "factoryTable", true);
factoryTable.forEach((clientId, instance) -> instance.shutdown());
factoryTable.clear();
mQClientFactory = null;
mqClientInstance = null;
traceMqClientInstance = null;
asyncTraceDispatcher = null;
traceProducer = null;
rebalanceImpl = null;
offsetStore = null;
litePullConsumerImpl = null;
}

@After
public void destroy() {
if (traceProducer != null) {
MQClientInstance traceClientFactory = traceProducer.getDefaultMQProducerImpl().getMqClientFactory();
traceClientFactory.unregisterProducer(producerGroupTraceTemp);
traceClientFactory.unregisterProducer(traceProducer.getProducerGroup());
}

if (traceMqClientInstance != null && traceProducer != null) {
traceMqClientInstance.unregisterProducer(traceProducer.getProducerGroup());
traceMqClientInstance.shutdown();
}

if (litePullConsumerImpl != null) {
if (mQClientFactory != null) {
mQClientFactory.unregisterConsumer(litePullConsumerImpl.groupName());
mQClientFactory.shutdown();
}

if (mqClientInstance != null && mqClientInstance != mQClientFactory) {
mqClientInstance.unregisterConsumer(litePullConsumerImpl.groupName());
mqClientInstance.shutdown();
}
}
}

@Test
Expand All @@ -126,8 +160,8 @@ public void testSubscribe_PollMessageSuccess_WithDefaultTraceTopic() throws Exce
Set<MessageQueue> messageQueueSet = new HashSet<>();
messageQueueSet.add(createMessageQueue());
litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet);
litePullConsumer.setPollTimeoutMillis(20 * 1000);
List<MessageExt> result = litePullConsumer.poll();
List<MessageExt> result = pollUntilFound(litePullConsumer);
assertThat(result).isNotEmpty();
assertThat(result.get(0).getTopic()).isEqualTo(topic);
assertThat(result.get(0).getBody()).isEqualTo(new byte[] {'a'});
} finally {
Expand All @@ -142,8 +176,8 @@ public void testSubscribe_PollMessageSuccess_WithCustomizedTraceTopic() throws E
Set<MessageQueue> messageQueueSet = new HashSet<>();
messageQueueSet.add(createMessageQueue());
litePullConsumerImpl.updateTopicSubscribeInfo(topic, messageQueueSet);
litePullConsumer.setPollTimeoutMillis(20 * 1000);
List<MessageExt> result = litePullConsumer.poll();
List<MessageExt> result = pollUntilFound(litePullConsumer);
assertThat(result).isNotEmpty();
assertThat(result.get(0).getTopic()).isEqualTo(topic);
assertThat(result.get(0).getBody()).isEqualTo(new byte[] {'a'});
} finally {
Expand All @@ -154,11 +188,15 @@ public void testSubscribe_PollMessageSuccess_WithCustomizedTraceTopic() throws E
@Test
public void testLitePullConsumerWithTraceTLS() throws Exception {
DefaultLitePullConsumer consumer = new DefaultLitePullConsumer("consumerGroup");
consumer.setUseTLS(true);
consumer.setEnableMsgTrace(true);
consumer.start();
AsyncTraceDispatcher asyncTraceDispatcher = (AsyncTraceDispatcher) consumer.getTraceDispatcher();
Assert.assertTrue(asyncTraceDispatcher.getTraceProducer().isUseTLS());
try {
consumer.setUseTLS(true);
consumer.setEnableMsgTrace(true);
consumer.start();
AsyncTraceDispatcher asyncTraceDispatcher = (AsyncTraceDispatcher) consumer.getTraceDispatcher();
Assert.assertTrue(asyncTraceDispatcher.getTraceProducer().isUseTLS());
} finally {
consumer.shutdown();
}
}

private DefaultLitePullConsumer createLitePullConsumerWithDefaultTraceTopic() throws Exception {
Expand Down Expand Up @@ -192,15 +230,26 @@ private void initDefaultLitePullConsumer(DefaultLitePullConsumer litePullConsume
litePullConsumerImpl = (DefaultLitePullConsumerImpl) field.get(litePullConsumer);
field = DefaultLitePullConsumerImpl.class.getDeclaredField("mQClientFactory");
field.setAccessible(true);
mqClientInstance = (MQClientInstance) field.get(litePullConsumerImpl);
mQClientFactory = spy(mqClientInstance);
mQClientFactory.getClientConfig().setDecodeReadBody(true);
field.set(litePullConsumerImpl, mQClientFactory);

field = MQClientInstance.class.getDeclaredField("rebalanceService");
field.setAccessible(true);
RebalanceService rebalanceService = (RebalanceService) field.get(mQClientFactory);
field = RebalanceService.class.getDeclaredField("waitInterval");
field.setAccessible(true);
field.set(rebalanceService, 100);

PullAPIWrapper pullAPIWrapper = litePullConsumerImpl.getPullAPIWrapper();
field = PullAPIWrapper.class.getDeclaredField("mQClientFactory");
field.setAccessible(true);
field.set(pullAPIWrapper, mQClientFactory);

Field fieldTrace = DefaultMQProducerImpl.class.getDeclaredField("mQClientFactory");
fieldTrace.setAccessible(true);
traceMqClientInstance = traceProducer.getDefaultMQProducerImpl().getMqClientFactory();
fieldTrace.set(traceProducer.getDefaultMQProducerImpl(), mQClientFactory);

field = MQClientInstance.class.getDeclaredField("mQClientAPIImpl");
Expand All @@ -225,6 +274,8 @@ private void initDefaultLitePullConsumer(DefaultLitePullConsumer litePullConsume

traceProducer.getDefaultMQProducerImpl().getMqClientFactory().registerProducer(producerGroupTraceTemp, traceProducer.getDefaultMQProducerImpl());

lenient().when(mQClientAPIImpl.getTopicRouteInfoFromNameServer(anyString(), anyLong())).thenReturn(createTopicRoute());

when(mQClientFactory.getMQClientAPIImpl().pullMessage(anyString(), any(PullMessageRequestHeader.class),
anyLong(), any(CommunicationMode.class), nullable(PullCallback.class)))
.thenAnswer(new Answer<Object>() {
Expand Down Expand Up @@ -252,6 +303,19 @@ public Object answer(InvocationOnMock mock) throws Throwable {

}

private List<MessageExt> pollUntilFound(DefaultLitePullConsumer litePullConsumer) {
litePullConsumer.setPollTimeoutMillis(1000);
long deadline = System.currentTimeMillis() + 20 * 1000;
List<MessageExt> result = Collections.emptyList();
while (System.currentTimeMillis() < deadline) {
result = litePullConsumer.poll();
if (!result.isEmpty()) {
return result;
}
}
return result;
}

private PullResultExt createPullResult(PullMessageRequestHeader requestHeader, PullStatus pullStatus,
List<MessageExt> messageExtList) throws Exception {
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
Expand Down
1 change: 1 addition & 0 deletions test/src/test/java/org/apache/rocketmq/test/grpc/v2/GrpcBaseIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,7 @@ public void testConsumeOrderly() throws Exception {
}

public void testSimpleConsumerSendAndRecvPriorityMessage() throws Exception {
brokerController1.getBrokerConfig().setPriorityOrderAsc(true);
String topic = initTopicOnSampleTopicBroker(BROKER1_NAME, TopicMessageType.PRIORITY);
String group = MQRandomUtils.getRandomConsumerGroup();
initConsumerGroup(group);
Expand Down
Loading