Skip to content

[ISSUE #10161] reduce bytes copy #10162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuz10 merged 2 commits into from
Mar 17, 2026
Merged

[ISSUE #10161] reduce bytes copy #10162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d99ad8
reduce bytes copy
ChineseTony Mar 10, 2026
dd06445
reduce bytes copy
ChineseTony Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 6 additions & 17 deletions remoting/src/main/java/org/apache/rocketmq/remoting/protocol/RemotingSerializable.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ public static byte[] encode(final Object obj) {
if (obj == null) {
return null;
}
final String json = toJson(obj, false);
return json.getBytes(CHARSET_UTF8);
return JSON.toJSONBytes(obj, CHARSET_UTF8);
}

public static String toJson(final Object obj, boolean prettyFormat) {
Expand All @@ -45,31 +44,22 @@ public static <T> T decode(final byte[] data, Class<T> classOfT) {
if (data == null) {
return null;
}
return fromJson(data, classOfT);
return JSON.parseObject(data, classOfT);
}

public static <T> List<T> decodeList(final byte[] data, Class<T> classOfT) {
if (data == null) {
return null;
}
String json = new String(data, CHARSET_UTF8);
return JSON.parseArray(json, classOfT);
return JSON.parseArray(data, 0, data.length, CHARSET_UTF8, classOfT);
}

public static <T> T fromJson(String json, Class<T> classOfT) {
return JSON.parseObject(json, classOfT);
}

private static <T> T fromJson(byte[] data, Class<T> classOfT) {
return JSON.parseObject(data, classOfT);
}

public byte[] encode() {
final String json = this.toJson();
if (json != null) {
return json.getBytes(CHARSET_UTF8);
}
return null;
return JSON.toJSONBytes(this, CHARSET_UTF8);
}

/**
Expand All @@ -79,8 +69,7 @@ public byte[] encode() {
* @return serialized data.
*/
public byte[] encode(JSONWriter.Feature... features) {
final String json = JSON.toJSONString(this, features);
return json.getBytes(CHARSET_UTF8);
return JSON.toJSONBytes(this, CHARSET_UTF8, features);
}

public String toJson() {
Expand All @@ -90,4 +79,4 @@ public String toJson() {
public String toJson(final boolean prettyFormat) {
return toJson(this, prettyFormat);
}
}
}
Loading