Closed
Conversation
The workflow_run triggered pr-e2e-test.yml downloads PR-built artifacts and pushes Docker images to official apache/rocketmq-ci DockerHub repo with secrets, allowing attackers to inject backdoored binaries via PRs. Remove the vulnerable workflow since push-ci.yml already provides full E2E test coverage after code is merged into develop/master.
pr-ci.yml only existed to build artifacts for the now-removed pr-e2e-test.yml. PR compilation is already covered by integration-test.yml and coverage.yml.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #10212 +/- ##
=============================================
- Coverage 48.94% 48.85% -0.09%
+ Complexity 13381 13359 -22
=============================================
Files 1373 1373
Lines 99904 99904
Branches 12901 12901
=============================================
- Hits 48896 48808 -88
- Misses 45076 45146 +70
- Partials 5932 5950 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
How Did You Test This Change?