Fix start() and shutdown() of DefaultMessagingProcessor#7838
Fix start() and shutdown() of DefaultMessagingProcessor#7838yuz10 merged 2 commits intoapache:developfrom
Conversation
|
|
||
| protected void init() { | ||
| this.appendStartAndShutdown(this.serviceManager); | ||
| this.appendStartAndShutdown(producerProcessor); |
There was a problem hiding this comment.
It seems that it's not necessary to start processors because this issue is only related to receiptHandleManager.
There was a problem hiding this comment.
It seems that it's not necessary to start processors because this issue is only related to receiptHandleManager.
Indeed, this issue is only related to receiptHandleProcessor. But all these processors extend AbstractStartAndShutdown and there is no caller, which may be error-prone over time?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7838 +/- ##
=============================================
+ Coverage 42.95% 49.86% +6.91%
- Complexity 9909 15036 +5127
=============================================
Files 1190 1384 +194
Lines 85984 116757 +30773
Branches 11079 17246 +6167
=============================================
+ Hits 36932 58222 +21290
- Misses 44472 52041 +7569
- Partials 4580 6494 +1914 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
any update? |
|
This PR is stale because it has been open for 365 days with no activity. It will be closed in 3 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. |
|
This PR was closed because it has been inactive for 3 days since being marked as stale. |
6 participants
Which Issue(s) This PR Fixes
Fixes #7837
Brief Description
How Did You Test This Change?
UT