[ISSUE #8283] Simplify the code related to cold reading control service#8284
Open
weihubeats wants to merge 22 commits intoapache:developfrom
Open
[ISSUE #8283] Simplify the code related to cold reading control service#8284weihubeats wants to merge 22 commits intoapache:developfrom
weihubeats wants to merge 22 commits intoapache:developfrom
Conversation
…o weihubeats/develop
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8284 +/- ##
=============================================
- Coverage 48.15% 47.97% -0.18%
+ Complexity 12027 11984 -43
=============================================
Files 1308 1308
Lines 92253 92252 -1
Branches 11808 11808
=============================================
- Hits 44425 44260 -165
- Misses 42343 42487 +144
- Partials 5485 5505 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lizhimins
previously approved these changes
Jul 12, 2024
lizhimins
changed the title
caigy
previously approved these changes
Jul 12, 2024
Member
Author
|
maybe this pr can merge |
…taCgCtrService # Conflicts: # broker/src/main/java/org/apache/rocketmq/broker/coldctr/ColdDataCgCtrService.java
Member
Author
|
@lizhimins Can you help review this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8283