Skip to content

[ISSUE #9246] Support init offset mode in PopConsumerService#9247

Merged
lizhimins merged 1 commit intoapache:developfrom
lizhimins:fix-9246
Mar 15, 2025
Merged

[ISSUE #9246] Support init offset mode in PopConsumerService#9247
lizhimins merged 1 commit intoapache:developfrom
lizhimins:fix-9246

Conversation

@lizhimins
Copy link
Copy Markdown
Member

Which Issue(s) This PR Fixes

Fixes #9246

Brief Description

How Did You Test This Change?

Copy link
Copy Markdown
Contributor

@lollipopjin lollipopjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 48.02%. Comparing base (622c807) to head (9baa23c).
Report is 47 commits behind head on develop.

Files with missing lines Patch % Lines
...apache/rocketmq/broker/pop/PopConsumerService.java 25.00% 7 Missing and 2 partials ⚠️
...rocketmq/broker/processor/PopMessageProcessor.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9247      +/-   ##
=============================================
- Coverage      48.06%   48.02%   -0.05%     
+ Complexity     12102    12092      -10     
=============================================
  Files           1322     1322              
  Lines          93105    93115      +10     
  Branches       11936    11938       +2     
=============================================
- Hits           44753    44717      -36     
- Misses         42811    42862      +51     
+ Partials        5541     5536       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizhimins lizhimins merged commit 054f910 into apache:develop Mar 15, 2025
10 of 11 checks passed
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Support init offset mode in PopConsumerService

3 participants