[ISSUE #9253] Make the message visible earlier when response process encounters errors#9255
Merged
lizhimins merged 2 commits intoapache:developfrom May 13, 2025
Merged
[ISSUE #9253] Make the message visible earlier when response process encounters errors#9255lizhimins merged 2 commits intoapache:developfrom
lizhimins merged 2 commits intoapache:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9255 +/- ##
=============================================
- Coverage 48.08% 48.02% -0.06%
+ Complexity 12108 12103 -5
=============================================
Files 1322 1322
Lines 93127 93138 +11
Branches 11940 11941 +1
=============================================
- Hits 44782 44732 -50
- Misses 42807 42862 +55
- Partials 5538 5544 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
qianye1001
reviewed
Mar 20, 2025
| if (PopStatus.FOUND.equals(popResult.getPopStatus())) { | ||
| GrpcClientChannel clientChannel = grpcChannelManager.getChannel(ctx.getClientID()); | ||
| if (clientChannel == null) { | ||
| RuntimeException e = new RuntimeException( |
Contributor
There was a problem hiding this comment.
RuntimeException will be convert to INTERNAL_SERVER_ERROR, It is recommended to use GrpcProxyException to return ok and carry error messages
Contributor
Author
There was a problem hiding this comment.
RuntimeException will be convert to INTERNAL_SERVER_ERROR, It is recommended to use GrpcProxyException to return ok and carry error messages
Fixed. PTAL.
lizhimins
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9253
Brief Description
How Did You Test This Change?