Skip to content

[ISSUE #9259] Remove duplicate flushing operation of StoreCheckpoint#9260

Merged
lizhimins merged 1 commit intoapache:developfrom
mxsm:op-9259
Mar 20, 2025
Merged

[ISSUE #9259] Remove duplicate flushing operation of StoreCheckpoint#9260
lizhimins merged 1 commit intoapache:developfrom
mxsm:op-9259

Conversation

@mxsm
Copy link
Copy Markdown
Member

@mxsm mxsm commented Mar 18, 2025

Which Issue(s) This PR Fixes

Fixes #9259

Brief Description

How Did You Test This Change?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.02%. Comparing base (2219fd8) to head (adbfe2a).
⚠️ Report is 225 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9260      +/-   ##
=============================================
- Coverage      48.08%   48.02%   -0.07%     
+ Complexity     12108    12102       -6     
=============================================
  Files           1322     1322              
  Lines          93127    93126       -1     
  Branches       11940    11940              
=============================================
- Hits           44782    44721      -61     
- Misses         42807    42859      +52     
- Partials        5538     5546       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@qianye1001 qianye1001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins changed the title [ISSUE #9259]Remove the duplicate flushing of storeCheckpoint [ISSUE #9259] Remove duplicate flushing operation of StoreCheckpoint Mar 20, 2025
@lizhimins lizhimins merged commit 34c32d8 into apache:develop Mar 20, 2025
10 of 11 checks passed
@mxsm mxsm deleted the op-9259 branch March 20, 2025 05:52
DivyanshIITB pushed a commit to DivyanshIITB/rocketmq that referenced this pull request Mar 20, 2025
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove the duplicate flushing of storeCheckpoint

5 participants