Skip to content

[ISSUE #8701] Fix documentation for brokerAddrTable property in MQClientInstance.java#9263

Merged
RongtongJin merged 1 commit intoapache:developfrom
DivyanshIITB:fix-brokerAddrTable-doc-clean
Mar 20, 2025
Merged

[ISSUE #8701] Fix documentation for brokerAddrTable property in MQClientInstance.java#9263
RongtongJin merged 1 commit intoapache:developfrom
DivyanshIITB:fix-brokerAddrTable-doc-clean

Conversation

@DivyanshIITB
Copy link
Copy Markdown
Contributor

@DivyanshIITB DivyanshIITB commented Mar 19, 2025

Clarified that the key of the brokerAddrTable map is the brokerName, not brokerClusterName, to prevent ambiguity.
Closes #8701

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.06%. Comparing base (2219fd8) to head (04988c5).
⚠️ Report is 298 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9263      +/-   ##
=============================================
- Coverage      48.08%   48.06%   -0.03%     
+ Complexity     12108    12099       -9     
=============================================
  Files           1322     1322              
  Lines          93127    93127              
  Branches       11940    11940              
=============================================
- Hits           44782    44758      -24     
- Misses         42807    42822      +15     
- Partials        5538     5547       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DivyanshIITB
Copy link
Copy Markdown
Contributor Author

Just a gentle reminder
@RongtongJin

@RongtongJin RongtongJin changed the title Fix documentation for brokerAddrTable property in MQClientInstance.java [ISSUE #8701] Fix documentation for brokerAddrTable property in MQClientInstance.java Mar 20, 2025
@RongtongJin
Copy link
Copy Markdown
Contributor

LGTM~

@RongtongJin RongtongJin merged commit 27c2916 into apache:develop Mar 20, 2025
10 of 11 checks passed
DivyanshIITB added a commit to DivyanshIITB/rocketmq that referenced this pull request Mar 20, 2025
3424672656 pushed a commit to 3424672656/rocketmq that referenced this pull request May 12, 2025
RongtongJin pushed a commit that referenced this pull request Jul 19, 2025
ChineseTony pushed a commit to ChineseTony/rocketmq that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc] Description of the brokerAddrTable property in MQClientInstance

3 participants